feat: add opentelemetry variables #8834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangxikun
suggested changes
Feb 12, 2023
apisix/plugins/opentelemetry.lua
Outdated
| @@ -333,6 +333,12 @@ function _M.rewrite(conf, api_ctx) | |||
| kind = span_kind.server, | |||
| attributes = attributes, | |||
| }) | |||
|
|
|||
| local span_context = ctx.sp:context() | |||
There was a problem hiding this comment.
use ctx:span():context()
apisix/plugins/opentelemetry.lua
Outdated
| @@ -333,6 +333,12 @@ function _M.rewrite(conf, api_ctx) | |||
| kind = span_kind.server, | |||
| attributes = attributes, | |||
| }) | |||
|
|
|||
| local span_context = ctx.sp:context() | |||
| ngx.var.opentelemetry_context_traceparent = string.format("00-%s-%s-%02x",span_context.trace_id, span_context.span_id, span_context.trace_flags) | |||
There was a problem hiding this comment.
missing space before span_context.trace_id
apisix/plugins/opentelemetry.lua
Outdated
| local span_context = ctx.sp:context() | ||
| ngx.var.opentelemetry_context_traceparent = string.format("00-%s-%s-%02x",span_context.trace_id, span_context.span_id, span_context.trace_flags) | ||
| ngx.var.opentelemetry_trace_id = span_context.trace_id | ||
| ngx.var.opentelemetry_span_id = span_context.span_id |
There was a problem hiding this comment.
We should add a bool field set_ngx_var(default false) in opentelemetry attr_schema, so user can enable/disable it, and keep backward compatibility.
shreemaan-abhishek
requested changes
Feb 12, 2023
| @@ -89,6 +89,31 @@ plugin_attr: | |||
| max_export_batch_size: 2 | |||
| ``` | |||
|
|
|||
| ## Variables | |||
|
|
|||
| The following nginx variables are set by the opentelemetry: | |||
There was a problem hiding this comment.
Suggested change
| The following nginx variables are set by the opentelemetry: | |
| The following nginx variables are set by OpenTelemetry: |
| - `opentelemetry_trace_id` - Trace Id of the current span | ||
| - `opentelemetry_span_id` - Span Id of the current span | ||
|
|
||
| How to use variables ？you have to add it to your configuration file (`conf/config.yaml`): |
There was a problem hiding this comment.
Suggested change
| How to use variables ？you have to add it to your configuration file (`conf/config.yaml`): | |
| How to use variables? You have to add it to your configuration file (`conf/config.yaml`): |
|
@yangxikun @shreemaan-abhishek Thank you for the suggestion, has completed the revision. |
|
I synced the fork, which caused this pr to close. I brought up a new pr #8871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Span information recorded in the access log.
Fixes # #8765
Checklist