-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle_extra_info add set req body #8884
Conversation
fix:handle_extra_info |
You should add a type。in apisix/apisix-3.1.0/deps/share/lua/5.1/A6/ExtraInfo |
add extra info type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -288,7 +288,14 @@ local function handle_extra_info(ctx, input) | |||
|
|||
local res | |||
local info_type = req:InfoType() | |||
if info_type == extra_info.Var then | |||
if info_type == extra_info.RespBody + 1 then --4 set_body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new field in https://github.com/api7/ext-plugin-proto?
You can read https://github.com/apache/apisix/blob/master/docs/en/latest/internal/plugin-runner.md for the implemented detail.
feature required |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
Is this the same as #9990? @monkeyDluffy6017 |
@moonming It's two different things |
So what problems and scenarios does this PR solve? @monkeyDluffy6017 |
@hongdingyi what problem does this PR solve? |
This PR requires to add a field in this file https://github.com/api7/ext-plugin-proto/blob/4af76c210e00ead699489cfeb055d8b9bb7596ed/ext-plugin.fbs#L121 @moonming @shreemaan-abhishek @monkeyDluffy6017 Conclusion: @hongdingyi In case I am missing some scenario where this actually will be required and just setting the request body using the Reply of the RPC wouldn't justify the use case, please let me know. |
let's wait for @hongdingyi's input. It seems the github actions were not triggered properly so I just made them re-run. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
@hongdingyi are you still working on the pr? |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
@hongdingyi Can you fix the lint check? |
closed because reason not provided |
Description
Fixes # (issue)
Checklist