Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBD Documentation Correction #1

Closed
wants to merge 7,915 commits into from
Closed

DBD Documentation Correction #1

wants to merge 7,915 commits into from

Conversation

dannyarcher
Copy link

correcting the documentation of dbd routines. Specictialy the use of strain length representations rather than apr_size_t*.

wrowe and others added 30 commits January 28, 2011 02:26
@wrowe
This was messed up in the rename to libaprapp-n.lib, solve make install
ac41c5a 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1064429 13f79535-47bb-0310-9956-ffa450edef68
Fix endianness issue in Oracle driver
4afcf6f 
PR 50690 - Patch from Stefan Ruppert


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1065258 13f79535-47bb-0310-9956-ffa450edef68
Axed C++ comments.
905012f 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1068870 13f79535-47bb-0310-9956-ffa450edef68
Disable getpass() for HP-UX platform (PR49496).
f9d4f16 
Reported by rajeshkc yahoo.com.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1070855 13f79535-47bb-0310-9956-ffa450edef68
note that keys are case insensitive
04a20f6 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1072159 13f79535-47bb-0310-9956-ffa450edef68
Add new configure option --enable-allocator-uses-mmap to use mmap
b0bcaf2 
instead of malloc in apr_allocator_alloc(). This greatly reduces 
memory fragmentation with malloc implementations (e.g. glibc) that
don't handle allocationss of a page-size-multiples in an efficient way. 
It also makes apr_allocator_max_free_set() actually have some effect
on such platforms.

The handling of page sizes other than 4k seems like a lot of trouble for a
very small number of platforms, but there does not seem to be a reasonable
way to check this at compile time.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1072165 13f79535-47bb-0310-9956-ffa450edef68
@trawick
add hook function args to the hook probe invocations
04a0939 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1072937 13f79535-47bb-0310-9956-ffa450edef68
apr_file_flush_locked(): Handle short writes
1eb82c7 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1073142 13f79535-47bb-0310-9956-ffa450edef68
@trawick
sync up with hook probe macro changes in r1072937
0ae39a1 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1073198 13f79535-47bb-0310-9956-ffa450edef68
Axed C++ comments and tabs.
22f7294 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1074811 13f79535-47bb-0310-9956-ffa450edef68
Axed C++ comments and tabs.
92727f9 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1074817 13f79535-47bb-0310-9956-ffa450edef68
Makr APR_RING_HEAD pointers volatile to work around an aliasing probl…
a368ffd 
…em that

causes gcc 4.5 to miscompile some brigade related code.

PR 50190


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1074876 13f79535-47bb-0310-9956-ffa450edef68
clarify docs for apr_file_gets
ba69d8b 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1074899 13f79535-47bb-0310-9956-ffa450edef68
@rpluem
* Remove empty [ ] block as it causes an empty "else fi" block that the
d42e8f2 
  shell does not like.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1076133 13f79535-47bb-0310-9956-ffa450edef68
Set eol-style native.
99e00cb 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1076915 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
9a80214 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1076916 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
35152b8 
Part 2.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1077882 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
b2ba1e4 
Part 3.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078199 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
4308870 
Fix a c&p error.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078205 13f79535-47bb-0310-9956-ffa450edef68
@trawick
style changes only -- make it look a lot more like the bulk of APR
1484b6b 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078507 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
b56d4f5 
Part 4.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078559 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
e3df718 
Part 5.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078617 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
6a20209 
Fixed typo.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078619 13f79535-47bb-0310-9956-ffa450edef68
NetWare build overhaul in order to compile on Linux.
26ca37b 
Fix for crappy linker which cant deal with absolute unix
paths for import files.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078631 13f79535-47bb-0310-9956-ffa450edef68
Fixed compilation when APR_HAVE_STRUCT_RLIMIT=0.
b029e03 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078655 13f79535-47bb-0310-9956-ffa450edef68
Fixed NetWare prototype warnings.
2f87a8c 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078658 13f79535-47bb-0310-9956-ffa450edef68
@trawick
fix some existing parameter range checking that had a bad
c88e7fa 
assumption about the size of array entries

add the same range check in another path


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078737 13f79535-47bb-0310-9956-ffa450edef68
@trawick
replace some strcpy() calls with apr_cpystrn()
048c21f 
(no overflow currently)


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078744 13f79535-47bb-0310-9956-ffa450edef68
Fix definition of apr_ino_t to be independent of _FILE_OFFSET_BITS even
a532b64 
if ino_t is 'unsigned int' (this case was not caught by
APR_CHECK_TYPES_COMPATIBLE(... unsigned long...) ).
Also don't limit the special handling to 32bit platforms, as there are
platforms (e.g. kfreebsd-gnu-amd64) where _FILE_OFFSET_BITS influences ino_t
even on 64bit.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078845 13f79535-47bb-0310-9956-ffa450edef68
Added dbm stuff to NetWare build.
79d75b7 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1078963 13f79535-47bb-0310-9956-ffa450edef68
minfrin and others added 24 commits November 28, 2011 22:56
@minfrin
RPM: Ensure we depend correctly on libuuid-devel at build time.
d589f0f 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1207679 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
Remove variables that we assign but never read.
7315c6a 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1207680 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
Suppress a potential warning about an ignored return value.
ccb47c7 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1207704 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
Update the crypto notices for apr_crypto.
34ecbae 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1209490 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
apr_crypto: Clear out buffers that are allocated by us when the pool …
37d3bae 
…from

which the memory was allocated from is cleaned up.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1210524 13f79535-47bb-0310-9956-ffa450edef68
@notroj
* include/: Fix doxygen group for headers from apr-util.
fe19a2b 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1211928 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
apr_crypto: Move the static initialisation of DRIVER_LOAD from
ad6ff3e 
apr_crypto_init() to apr_crypto_get_driver(), so that we don't lose
the parameters.


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1211987 13f79535-47bb-0310-9956-ffa450edef68
@mturk
Backport windows crypto build files from apr-util. We still need port…
75dfa1c 
… module build part for Makefile.win

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1212119 13f79535-47bb-0310-9956-ffa450edef68
@trawick
definAtely
d37b11e 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1213382 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
apr_crypto: Crypto library detection runs twice (from main configure …
4feab84 
…logic

as well as from APU_CHECK_CRYPTO). Crypto enablement depends on enablement
of a crypto library, but forgetting to enable a crypto library silently
proceeds without failing.
Submitted by: trawick


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1214516 13f79535-47bb-0310-9956-ffa450edef68
Fix "test" syntax introduced in r1214516.
8a26cb5 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1220395 13f79535-47bb-0310-9956-ffa450edef68
Randomise hashes by providing a seed.
3239eaa 
This is supposed to be a "good enough" approach. Using a crypto quality
function like apr_generate_random_bytes() may be stronger, but this function
may block, so it will be avoided for now.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1231605 13f79535-47bb-0310-9956-ffa450edef68
Do no use srand()/rand() to randomise hashes. Use just "random" data …
e25fc80 
…instead.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1231858 13f79535-47bb-0310-9956-ffa450edef68
Revert hash randomisation for now. Causing regressions in httpd.
ecf3a62 
It is incomplete and possibly incorrect as well.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1232320 13f79535-47bb-0310-9956-ffa450edef68
Clarify docs
9bbe952 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1234474 13f79535-47bb-0310-9956-ffa450edef68
@pgollucci
Fix compile w/ clang and IPv6
6b6bf71 
Submitted by:  Yuri Pankov <yuri.pankov@gmail.com>
               via freebsd ports/164420



git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1235047 13f79535-47bb-0310-9956-ffa450edef68
Randomise hashes by providing a seed.
6541e54 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1236642 13f79535-47bb-0310-9956-ffa450edef68
Revert hash randomisation again. Elegant, but ultimately ineffective.
4cf996a 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1236967 13f79535-47bb-0310-9956-ffa450edef68
Randomise hashes by providing a seed (initial hash value).
f5744a2 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1236970 13f79535-47bb-0310-9956-ffa450edef68
Further improve hash randomisation:
4b09889 
Fix naming of a static function.
Randomise final hash produced by any hash function, using default hash
function and seed.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1237078 13f79535-47bb-0310-9956-ffa450edef68
Fix doxygen typos in apr_buckets.h.
598a57c 
Patch by Hiroaki KAWAI <kawai at apache.org>.
PR: 52521.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1237208 13f79535-47bb-0310-9956-ffa450edef68
Revert r1237078 partially: do not hash the hash.
e26e417 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1237507 13f79535-47bb-0310-9956-ffa450edef68
Reserve a range of USERERR values for HTTPD
760ae57 
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1240472 13f79535-47bb-0310-9956-ffa450edef68
@dannyarcher
DBD Documentation Correction
45410ae 
correcting the documentation of dbd routines. Specictialy the use of strain length representations rather than apr_size_t*.
@asfgit asfgit closed this Aug 16, 2015
asfgit pushed a commit that referenced this pull request Dec 16, 2020
@ylavic
Merge r1883750 from trunk:
2b85c17 
apr_pools: lock parent pool in pool_destroy_debug().

By using apr_pool_clear_debug() instead of pool_clear_debug() in
pool_destroy_debug() we gain the locking provided by the former and thus
protection from concurrent access from apr_pool_walk_tree(), which is
undefined behaviour.

While pool_destroy_debug()=>apr_pool_clear_debug()=>pool_clear_debug() calls
pool_destroy_debug() for all the children pools, this does not cause a deadlock
because apr_pool_clear_debug() locks the parent pool only (not the pool itself)
and thus pool_destroy_debug(pool->child) locks the current pool with no issue.

This fixes use-after-free like the below in httpd (with -D APR_POOL_DEBUG):

=================================================================
==2026856==ERROR: AddressSanitizer: heap-use-after-free on address 0x60600025acf0 at pc 0x7fe738f4c5be bp 0x7fe718598110 sp 0x7fe718598108
READ of size 8 at 0x60600025acf0 thread T51
    #0 0x7fe738f4c5bd in apr_thread_mutex_lock locks/unix/thread_mutex.c:124
    #1 0x7fe738f4e01c in apr_pool_walk_tree memory/unix/apr_pools.c:1505
    #2 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #3 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #4 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #5 0x7fe738f5027c in apr_pool_find memory/unix/apr_pools.c:2291
    #6 0x7fe738f14aba in apr_table_mergen tables/apr_tables.c:746
    #7 0x5578ad926a25 in ap_set_keepalive /home/ylavic/src/apache/httpd/trunk/modules/http/http_protocol.c:309
    #8 0x5578ad93933f in ap_http_header_filter /home/ylavic/src/apache/httpd/trunk/modules/http/http_filters.c:1376
    #9 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #10 0x5578ad9a67f3 in ap_content_length_filter /home/ylavic/src/apache/httpd/trunk/server/protocol.c:2046
    #11 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #12 0x5578ad9405ae in ap_byterange_filter /home/ylavic/src/apache/httpd/trunk/modules/http/byterange_filter.c:463
    #13 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #14 0x7fe7330e398b in ap_headers_output_filter /home/ylavic/src/apache/httpd/trunk/modules/metadata/mod_headers.c:891
    #15 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #16 0x7fe732e32dba in session_output_filter /home/ylavic/src/apache/httpd/trunk/modules/session/mod_session.c:501
    #17 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #18 0x5578ad9c8ee5 in default_handler /home/ylavic/src/apache/httpd/trunk/server/core.c:5188
    #19 0x5578ad9431bb in ap_run_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:170
    #20 0x5578ad944941 in ap_invoke_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:444
    #21 0x5578ad92cc23 in ap_process_async_request /home/ylavic/src/apache/httpd/trunk/modules/http/http_request.c:463
    #22 0x5578ad924d7c in ap_process_http_async_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:158
    #23 0x5578ad925410 in ap_process_http_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:252
    #24 0x5578ad97e04d in ap_run_process_connection /home/ylavic/src/apache/httpd/trunk/server/connection.c:42
    #25 0x7fe735c7ef79 in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1097
    #26 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #27 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #28 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477
    #29 0x7fe738d6ed4e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xfdd4e)

0x60600025acf0 is located 48 bytes inside of 64-byte region [0x60600025acc0,0x60600025ad00)
freed by thread T63 here:
    #0 0x7fe7391ed277 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107277)
    #1 0x7fe738f4e9e5 in pool_clear_debug memory/unix/apr_pools.c:1893
    #2 0x7fe738f4ecb2 in pool_destroy_debug memory/unix/apr_pools.c:1956
    #3 0x7fe738f4eeeb in apr_pool_destroy_debug memory/unix/apr_pools.c:2002
    #4 0x5578ada2534b in ap_queue_info_push_pool /home/ylavic/src/apache/httpd/trunk/server/mpm_fdqueue.c:230
    #5 0x7fe735c81412 in process_lingering_close /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1686
    #6 0x7fe735c7f9bc in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1255
    #7 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #8 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #9 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x@1883751 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 16, 2020
@ylavic
apr_pools: lock parent pool in pool_destroy_debug().
94d2e04 
By using apr_pool_clear_debug() instead of pool_clear_debug() in
pool_destroy_debug() we gain the locking provided by the former and thus
protection from concurrent access from apr_pool_walk_tree(), which is
undefined behaviour.

While pool_destroy_debug()=>apr_pool_clear_debug()=>pool_clear_debug() calls
pool_destroy_debug() for all the children pools, this does not cause a deadlock
because apr_pool_clear_debug() locks the parent pool only (not the pool itself)
and thus pool_destroy_debug(pool->child) locks the current pool with no issue.

This fixes use-after-free like the below in httpd (with -D APR_POOL_DEBUG):

=================================================================
==2026856==ERROR: AddressSanitizer: heap-use-after-free on address 0x60600025acf0 at pc 0x7fe738f4c5be bp 0x7fe718598110 sp 0x7fe718598108
READ of size 8 at 0x60600025acf0 thread T51
    #0 0x7fe738f4c5bd in apr_thread_mutex_lock locks/unix/thread_mutex.c:124
    #1 0x7fe738f4e01c in apr_pool_walk_tree memory/unix/apr_pools.c:1505
    #2 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #3 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #4 0x7fe738f4e066 in apr_pool_walk_tree memory/unix/apr_pools.c:1511
    #5 0x7fe738f5027c in apr_pool_find memory/unix/apr_pools.c:2291
    #6 0x7fe738f14aba in apr_table_mergen tables/apr_tables.c:746
    #7 0x5578ad926a25 in ap_set_keepalive /home/ylavic/src/apache/httpd/trunk/modules/http/http_protocol.c:309
    #8 0x5578ad93933f in ap_http_header_filter /home/ylavic/src/apache/httpd/trunk/modules/http/http_filters.c:1376
    #9 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #10 0x5578ad9a67f3 in ap_content_length_filter /home/ylavic/src/apache/httpd/trunk/server/protocol.c:2046
    #11 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #12 0x5578ad9405ae in ap_byterange_filter /home/ylavic/src/apache/httpd/trunk/modules/http/byterange_filter.c:463
    #13 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #14 0x7fe7330e398b in ap_headers_output_filter /home/ylavic/src/apache/httpd/trunk/modules/metadata/mod_headers.c:891
    #15 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #16 0x7fe732e32dba in session_output_filter /home/ylavic/src/apache/httpd/trunk/modules/session/mod_session.c:501
    #17 0x5578ad98f7bd in ap_pass_brigade /home/ylavic/src/apache/httpd/trunk/server/util_filter.c:783
    #18 0x5578ad9c8ee5 in default_handler /home/ylavic/src/apache/httpd/trunk/server/core.c:5188
    #19 0x5578ad9431bb in ap_run_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:170
    #20 0x5578ad944941 in ap_invoke_handler /home/ylavic/src/apache/httpd/trunk/server/config.c:444
    #21 0x5578ad92cc23 in ap_process_async_request /home/ylavic/src/apache/httpd/trunk/modules/http/http_request.c:463
    #22 0x5578ad924d7c in ap_process_http_async_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:158
    #23 0x5578ad925410 in ap_process_http_connection /home/ylavic/src/apache/httpd/trunk/modules/http/http_core.c:252
    #24 0x5578ad97e04d in ap_run_process_connection /home/ylavic/src/apache/httpd/trunk/server/connection.c:42
    #25 0x7fe735c7ef79 in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1097
    #26 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #27 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #28 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477
    #29 0x7fe738d6ed4e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xfdd4e)

0x60600025acf0 is located 48 bytes inside of 64-byte region [0x60600025acc0,0x60600025ad00)
freed by thread T63 here:
    #0 0x7fe7391ed277 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107277)
    #1 0x7fe738f4e9e5 in pool_clear_debug memory/unix/apr_pools.c:1893
    #2 0x7fe738f4ecb2 in pool_destroy_debug memory/unix/apr_pools.c:1956
    #3 0x7fe738f4eeeb in apr_pool_destroy_debug memory/unix/apr_pools.c:2002
    #4 0x5578ada2534b in ap_queue_info_push_pool /home/ylavic/src/apache/httpd/trunk/server/mpm_fdqueue.c:230
    #5 0x7fe735c81412 in process_lingering_close /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1686
    #6 0x7fe735c7f9bc in process_socket /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:1255
    #7 0x7fe735c856a0 in worker_thread /home/ylavic/src/apache/httpd/trunk/server/mpm/event/event.c:2386
    #8 0x7fe738f7cef4 in dummy_worker threadproc/unix/thread.c:145
    #9 0x7fe738e3eea6 in start_thread nptl/pthread_create.c:477


git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1883750 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Sep 10, 2021
@ylavic
apr_crypto: fix potential memory leaks of cprng_stream_ctx_t.
398fc32 
This can happen in cprng_stream_ctx_make() on error paths, or at thread exit
with APR_CRYPTO_PRNG_PER_THREAD like the below.

Direct leak of 64 byte(s) in 8 object(s) allocated from:
    #0 0x7efd954c7628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x107628)
    #1 0x7efd921db6ca  (<unknown module>)
    #2 0x7efd952937a2 in apr_crypto_prng_create crypto/apr_crypto_prng.c:367
    #3 0x7efd95292c1e in apr_crypto_random_thread_bytes crypto/apr_crypto_prng.c:218
    #4 0x5611dbbb9440 in thread_func /home/yle/src/apache/apr/trunk.ro/test/testcrypto.c:2597
    #5 0x7efd9537dd86 in dummy_worker threadproc/unix/thread.c:148
    #6 0x7efd951efea6 in start_thread nptl/pthread_create.c:477



git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1893201 13f79535-47bb-0310-9956-ffa450edef68
monkburger pushed a commit to monkburger/apr that referenced this pull request Feb 25, 2022
Under certain circumstances, Apache will crash because apr_global_mut…
78567c7 
…ex_child_init() is being passed a NULL

mutex. We've seen this behavior under certain modules, specifically mod_lsapi and a few others under high load/IO wait during graceful restarts:

  #0  apr_proc_mutex_child_init (mutex=0x8, fname=0x0, pool=0x5566e972f128) at locks/unix/proc_mutex.c:1570
  apache#1  0x00002b9a5730cd2c in apr_global_mutex_child_init (mutex=<optimized out>, fname=<optimized out>, pool=<optimized out>) at locks/unix/global_mutex.c:89

With this patch, it shows the following - as well as no more segfaults:

[Fri Feb 25 01:13:58.924341 2022] [:emerg] [pid 92020] (20009)No lock was provided and one was required.: [host test.test] mod_lsapi:  apr_global_mutex_child_init error for pipe mutex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone