Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #20

Closed
lidavidm opened this issue Jun 16, 2022 · 1 comment · Fixed by #21
Closed

Improve error handling #20

lidavidm opened this issue Jun 16, 2022 · 1 comment · Fixed by #21

Comments

@lidavidm
Copy link
Member

We should fill out the error codes. Things to consider:

  • Flight/gRPC status codes: the gRPC status codes are nice because they're well-defined.
  • PEP 249 exception hierarchy
  • SQLSTATE standard (JDBC/ODBC)

Do we want to extend AdbcError with space for database-specific error codes?

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 16, 2022
This was referenced Jun 16, 2022
@pitrou
Copy link
Member

pitrou commented Jun 16, 2022

Do we want to extend AdbcError with space for database-specific error codes?

Probably? It seems that wouldn't hurt, and being possible to faithfully recreate errors is always a plus.

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 16, 2022
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 17, 2022
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 17, 2022
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 22, 2022
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 23, 2022
lidavidm added a commit that referenced this issue Jun 23, 2022
@lidavidm lidavidm added this to the 0.1.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants