Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Format][C][Java][Python] Simplify execute/query interface #69

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

lidavidm
Copy link
Member

While the interface is arguably more complicated now, it expresses whether you want a result set or not, which is a more natural mapping to existing APIs like JDBC/Flight SQL, and will help with the Postgres driver in #65.

Fixes #61.

Also related to #55.

@lidavidm lidavidm force-pushed the lidavidm/query-execute branch 2 times, most recently from ad03a0d to 3f18c92 Compare August 19, 2022 16:48
@lidavidm lidavidm changed the title [Format][C][Java] Simplify Execute/Query interface [Format][C][Java][Python] Simplify execute/query interface Aug 19, 2022
@lidavidm lidavidm marked this pull request as ready for review August 19, 2022 22:20
@hannes
Copy link

hannes commented Aug 26, 2022

I'm implementing the version from this PR in DuckDB now.

@lidavidm lidavidm merged commit d8c5821 into apache:main Aug 26, 2022
@lidavidm lidavidm deleted the lidavidm/query-execute branch August 26, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Format] Simplify Execute and Query interface
2 participants