Allow initial support for custom extension types #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10. This PR is large mainly because it adds fairly generic support for custom field metadata. We then use that support to add custom type extension for Symbol/Char vectors. We could perhaps factor this a bit more to make it even more generic for custom types, but I think this gets us pretty darn far.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 76.27% 77.78% +1.51%
==========================================
Files 13 13
Lines 1758 1819 +61
==========================================
+ Hits 1341 1415 +74
+ Misses 417 404 -13
Continue to review full report at Codecov.
|
quinnj
added a commit
that referenced
this pull request
Oct 3, 2020
* Allow initial support for custom extension types Fixes #10. This PR is large mainly because it adds fairly generic support for custom field metadata. We then use that support to add custom type extension for Symbol/Char vectors. We could perhaps factor this a bit more to make it even more generic for custom types, but I think this gets us pretty darn far. * Fix dict encoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10. This PR is large mainly because it adds fairly generic
support for custom field metadata. We then use that support to add
custom type extension for Symbol/Char vectors. We could perhaps factor
this a bit more to make it even more generic for custom types, but I
think this gets us pretty darn far.