Skip to content

Commit

Permalink
Remove old TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandreyc committed Aug 22, 2023
1 parent 01224e1 commit 46fa925
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions arrow-string/src/like.rs
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,6 @@ macro_rules! datum_function {
let left_type = left_array.data_type();
let right_type = right_array.data_type();

// TODO(alexandreyc): check if PartialEq for DataType is deep or shallow
// i.e. does it check nested subtypes for equality?
if left_type != right_type {
return Err(ArrowError::ComputeError(
"Arrays must have the same data type".to_string(),
Expand Down Expand Up @@ -916,7 +914,7 @@ mod tests {
vec![true, true, true, false, false, true, false, false]
);

// TODO
// OK
test_dict_utf8!(
test_utf8_array_like_dict,
vec!["arrow", "arrow", "arrow", "arrow", "arrow", "arrows", "arrow", "arrow"],
Expand Down

0 comments on commit 46fa925

Please sign in to comment.