Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV Reader String Dictionary Support #228

Closed
tustvold opened this issue Apr 27, 2021 · 0 comments · Fixed by #229
Closed

CSV Reader String Dictionary Support #228

tustvold opened this issue Apr 27, 2021 · 0 comments · Fixed by #229
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Now that the CSV writer supports dictionaries, it would be advantageous for the reader to also.

The major use-case for this would be for string dictionaries, which can make use of the existing DictionaryArray::from_iter implementation.
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 27, 2021
@tustvold
Support string dictionaries in csv reader (apache#228)
38801d6
@tustvold tustvold mentioned this issue Apr 27, 2021
Merged
nevi-me pushed a commit that referenced this issue Apr 27, 2021
@tustvold
Support string dictionaries in csv reader (#228) (#229)
111d5d6
@jorgecarleitao jorgecarleitao added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels May 14, 2021
@jorgecarleitao jorgecarleitao mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support string dictionaries in csv reader (#228) tustvold/arrow-rs
2 participants
@tustvold @jorgecarleitao