Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FFI support optional via Feature Flag ffi #2302

Closed
tustvold opened this issue Aug 3, 2022 · 1 comment · Fixed by #2303
Closed

Make FFI support optional via Feature Flag ffi #2302

tustvold opened this issue Aug 3, 2022 · 1 comment · Fixed by #2303
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Many use-cases will not need FFI support, and as such being able to disable FFI support will allow eliminating a large amount of non-trivial, unsafe code from their build

Describe the solution you'd like

I would like a feature flag to disable FFI support

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 3, 2022
@tustvold
Make FFI support optional (apache#2302)
e6b246b
@tustvold tustvold mentioned this issue Aug 3, 2022
Merged
tustvold added a commit that referenced this issue Aug 4, 2022
@tustvold
Make FFI support optional, change APIs to be safe (#2302) (#2303)
d87f6a4 
* Make FFI support optional (#2302)

* Fix integration test
@alamb alamb changed the title Make FFI support Optional via Feature Flag Make FFI support optional via Feature Flag ffi Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
@alamb
Copy link
Contributor

alamb commented Aug 4, 2022

added documentation about this flag in #2324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make FFI support optional, change APIs to be safe (#2302) tustvold/arrow-rs
2 participants
@alamb @tustvold