Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal Casts are Unchecked #2986

Closed
tustvold opened this issue Oct 30, 2022 · 3 comments · Fixed by #3076
Closed

Decimal Casts are Unchecked #2986

tustvold opened this issue Oct 30, 2022 · 3 comments · Fixed by #3076
Assignees
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

Describe the bug

Most numeric casts, e.g. Int16 - Int8, are checked and will return an error (or null) on overflow. By contrast the decimal conversions are not. In particular:

  • decimal to decimal conversion
  • float to decimal conversion
  • decimal to integer
  • integer to decimal

To Reproduce

Expected behavior

Additional context

I believe @viirya intends to work on this, but wanted to create a ticket so it didn't get lost

@tustvold tustvold added the bug label Oct 30, 2022
@viirya viirya self-assigned this Oct 30, 2022
@viirya
Copy link
Member

viirya commented Oct 30, 2022

Yea, thanks @tustvold

@alamb
Copy link
Contributor

alamb commented Nov 25, 2022

label_issue.py automatically added labels {'arrow'} from #3076

@alamb alamb added the arrow Changes to the arrow crate label Nov 25, 2022
@tustvold
Copy link
Contributor Author

Not sure if this should be reopened or a new issue created, but #3203 would suggest that truncation is not properly checked yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants