Fix new clippy lints introduced in Rust 1.58 #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 13, 2022
| @@ -244,6 +244,7 @@ impl std::ops::Deref for Buffer { | |||
| } | |||
|
|
|||
| unsafe impl Sync for Buffer {} | |||
| #[allow(clippy::non_send_fields_in_send_ty)] | |||
There was a problem hiding this comment.
The unsafe marker for Buffer worries me (perhaps related to the FFI deallocator?) -- I will file a ticket to look into it in more detail
In the interim, this code is no more sound/unsound than it was prior to clippy noticing this problem, so I think it would be ok to merge this PR in.
There was a problem hiding this comment.
I also found some discussion about this false positive, related to NonNull (which we use in Bytes), at rust-lang/rust-clippy#8045. For now disabling the warning here sounds good.
github-actions
bot
added
arrow
|
CI is failing due to #1169 -- so I plan to merge this PR and then that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its that time of month! Rust 1.58 has been released and with it some new clippy lints.
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1580-2022-01-13