Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin WASM / packed SIMD tests to nightly-2022-01-17 (#1204)" #1251

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 31, 2022

This reverts commit d68c4ae.

Which issue does this PR close?

Re #1198

Rationale for this change

Upstream issue rust-lang/packed_simd#341 seems to be resolved, so we can remove the pin and go back to using latest nightly for testing simd

What changes are included in this PR?

Revert #1204

Are there any user-facing changes?

No (CI only fix)

@alamb alamb added the development-process Related to development process of arrow-rs label Jan 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1251 (ae5dec3) into master (aac1844) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ae5dec3 differs from pull request most recent head dab9385. Consider uploading reports for the commit dab9385 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   82.96%   82.96%           
=======================================
  Files         178      178           
  Lines       51547    51547           
=======================================
+ Hits        42765    42767    +2     
+ Misses       8782     8780    -2     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 84.77% <0.00%> (+0.12%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac1844...dab9385. Read the comment docs.

@jhorstmann
Copy link
Contributor

Looks good. I saw the fix was announced on twitter

@alamb alamb merged commit c066a6c into apache:master Feb 1, 2022
@alamb alamb deleted the alamb/revert_pin branch February 1, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants