Fix simd comparison kernels #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb I'm sorry for only noticing this issue so late. Would be nice if we could still include it in the 9.0 release. |
|
@jhorstmann -- I agree this seems serious -- I'll make a new RC to include this |
alamb
approved these changes
Feb 7, 2022
| @@ -2442,6 +2442,20 @@ mod tests { | |||
| let b = b.slice(0, b.len()); | |||
| let c = $DYN_KERNEL(a.as_ref(), b.as_ref()).unwrap(); | |||
| assert_eq!(BooleanArray::from($EXPECTED), c); | |||
|
|
|||
There was a problem hiding this comment.
👍 in case anyone else is curious, without the code fix, this test fails like this:
---- compute::kernels::comparison::tests::test_primitive_array_eq stdout ----
thread 'compute::kernels::comparison::tests::test_primitive_array_eq' panicked at 'assertion failed: `(left == right)`
left: `BooleanArray
[
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
...80 elements...,
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
]`,
right: `BooleanArray
[
false,
false,
true,
true,
true,
true,
true,
true,
true,
true,
...80 elements...,
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
]`', arrow/src/compute/kernels/comparison.rs:2486:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
...
|
I plan to cherry-pick this and create a 9.0.1 branch / RC |
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Feb 7, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1285 .
Rationale for this change
The refactoring of the simd comparison in #1146 introduced silly mistake that was not noticed due to missing test coverage.
What changes are included in this PR?
Apart from the bugfix, this adjusts the tests so they automatically also test a larger version of the test input and so cover the chunked part.