filter kernel should work with FixedSizeListArrays
#1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 185 186 +1
Lines 53822 53894 +72
==========================================
+ Hits 44500 44569 +69
- Misses 9322 9325 +3
Continue to review full report at Codecov.
|
|
cc @alamb |
alamb
approved these changes
Mar 14, 2022
| list.as_any().downcast_ref::<Int32Array>().unwrap().values() | ||
| ); | ||
|
|
||
| let filter_array = BooleanArray::from(vec![true, false, true]); |
There was a problem hiding this comment.
👍 for taking something other than the first element
|
Hi @viirya -- there appear to be some conflicts in this PR now. Can you resolve them so I can get it merged? |
|
Yea, let me resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1393.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?