Use Option<T>
rather than Option<&T>
for copy types in substring kernel
#1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1556.
Rationale for this change
Suggested by @jhorstmann on #1571 (comment)
What changes are included in this PR?
Changes
Option<&T>
toOption<T>
whereT: Clone
Are there any user-facing changes?
Yes, this changes the signature of the substring kernel
FYI @tfeda