Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Option<T> rather than Option<&T> for copy types in substring kernel #1576

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Apr 17, 2022

Which issue does this PR close?

Closes #1556.

Rationale for this change

Suggested by @jhorstmann on #1571 (comment)

What changes are included in this PR?

Changes Option<&T> to Option<T> where T: Clone

Are there any user-facing changes?

Yes, this changes the signature of the substring kernel

FYI @tfeda

@tustvold tustvold added the api-change Changes to the arrow API label Apr 17, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 17, 2022
@alamb alamb changed the title Remove reference indirection for Copy types in substring Use Option<T> rather than Option<&T> for copy types in substring kernel Apr 17, 2022
@tustvold tustvold merged commit 791bfc4 into apache:master Apr 17, 2022
@alamb alamb removed the api-change Changes to the arrow API label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace &Option<T> with Option<&T> in some APIs
2 participants