Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: use the standard function div_ceil #1629

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None. It is just a small change.

What changes are included in this PR?

We should use the standard function div_ceil instead of implementing our own.

Are there any user-facing changes?

None

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1629 (79a964f) into master (7da41c7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 79a964f differs from pull request most recent head fd979b1. Consider uploading reports for the commit fd979b1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
- Coverage   83.03%   83.03%   -0.01%     
==========================================
  Files         193      193              
  Lines       55472    55469       -3     
==========================================
- Hits        46059    46056       -3     
  Misses       9413     9413              
Impacted Files Coverage Δ
arrow/src/util/bit_util.rs 100.00% <100.00%> (ø)
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
arrow/src/array/transform/mod.rs 86.68% <0.00%> (-0.12%) ⬇️
parquet/src/encodings/encoding.rs 93.56% <0.00%> (+0.18%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da41c7...fd979b1. Read the comment docs.

@alamb alamb merged commit 849ee2a into apache:master Apr 29, 2022
@alamb
Copy link
Contributor

alamb commented Apr 29, 2022

Thanks @HaoYang670

@HaoYang670 HaoYang670 deleted the cleanup_ceil branch April 29, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants