Pretty Print UnionArrays
#1648
Merged
Pretty Print UnionArrays
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 83.08% 83.09% +0.01%
==========================================
Files 193 193
Lines 55778 55858 +80
==========================================
+ Hits 46343 46416 +73
- Misses 9435 9442 +7
Continue to review full report at Codecov.
|
viirya
reviewed
May 5, 2022
Comment on lines
+735
to
+738
| builder.append::<Int32Type>("b", 1).unwrap(); | ||
| builder.append::<Float64Type>("c", 3.2234).unwrap(); | ||
| builder.append_null::<Float64Type>("c").unwrap(); | ||
| builder.append_null::<Int32Type>("b").unwrap(); |
There was a problem hiding this comment.
Can you let outer show one null value from inner UnionArray too?
arrow/src/util/display.rs
Outdated
Comment on lines
427
to
428
| "Repl error: could not get field for the corresponding type in union array." | ||
| .to_string(), |
There was a problem hiding this comment.
Maybe have type_id in error string?
viirya
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1594 .
Rationale for this change
What changes are included in this PR?
Pretty printing support for
UnionArray. My first stab is based on how they look in the specification, but I can change it according to any suggestions:Example:
Are there any user-facing changes?