Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin flatbuffers dependency version #1668

Merged
merged 1 commit into from
May 8, 2022

Conversation

Cheappie
Copy link
Contributor

@Cheappie Cheappie commented May 7, 2022

Which issue does this PR close?

Closes #1667

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1668 (e093656) into master (e0a527b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.01%     
==========================================
  Files         193      193              
  Lines       55850    55850              
==========================================
- Hits        46426    46422       -4     
- Misses       9424     9428       +4     
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.37% <0.00%> (-0.19%) ⬇️
arrow/src/array/transform/mod.rs 86.57% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a527b...e093656. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original change was made in #239 and doesn't appear to be relevant anymore. Thanks 👍

@tustvold tustvold merged commit 8b1ad09 into apache:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin Flatbuffer version dependency
3 participants