-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UnionArray FieldData using Type Erasure #1842
Implement UnionArray FieldData using Type Erasure #1842
Conversation
e9ace5e
to
0b464c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 201 201
Lines 56903 56871 -32
==========================================
- Hits 47511 47499 -12
+ Misses 9392 9372 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice cleanup to me.
I also checked and this does not appear to change any of the public API, which is 👍
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Follow on from #1591
Rationale for this change
mutable_buffer_to_builder
created an untyped back-door to creating aBufferBuilder<T>
with arbitraryMutableArray
. This makes it hard to reason about the invariants of theMutableArray
belonging to aBufferBuilder
.What changes are included in this PR?
This instead implements UnionArray using type-erasure, which is safer and less code.
Are there any user-facing changes?
No