Remove doc hidden from GenericColumnReader #2090
Conversation
| @@ -45,7 +45,6 @@ pub(crate) const MIN_BATCH_SIZE: usize = 1024; | |||
| pub type RecordReader<T> = | |||
| GenericRecordReader<ScalarBuffer<<T as DataType>::T>, ColumnValueDecoderImpl<T>>; | |||
|
|
|||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
Drive by cleanup, this module is private and so there is no user-facing change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2090 +/- ##
=======================================
Coverage 83.70% 83.70%
=======================================
Files 224 224
Lines 58967 58967
=======================================
Hits 49360 49360
Misses 9607 9607 ☔ View full report in Codecov by Sentry. |
|
Benchmark runs are scheduled for baseline = 1738a90 and contender = 13adaa7. 13adaa7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Currently the lack of docs makes it hard to determine how to use
ColumnReaderImpl- see here.The decision was initially made to hide these docs to allow us to evolve the API, however, I think it makes sense to unhide this API because: