Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array writer indirection #2091

merged 1 commit into from Jul 21, 2022


Copy link

@tustvold tustvold commented Jul 16, 2022

Which issue does this PR close?

Part of #1764

Rationale for this change

This adds a layer of indirection to ArrowWriter which will allow using custom ColumnValueEncoder with GenericColumnWriter to write values directly from their source arrow arrays.

What changes are included in this PR?

Adds a layer of indirection to ArrowWriter

Are there any user-facing changes?


@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 16, 2022
@tustvold tustvold marked this pull request as ready for review July 17, 2022 20:32
Copy link

Codecov Report

Merging #2091 (32c27fd) into master (02371d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2091   +/-   ##
  Coverage   83.73%   83.74%           
  Files         225      225           
  Lines       59373    59386   +13     
+ Hits        49715    49730   +15     
+ Misses       9658     9656    -2     
Impacted Files Coverage Δ
parquet/src/arrow/arrow_writer/ 97.56% <100.00%> (+0.02%) ⬆️
parquet/src/file/ 92.66% <100.00%> (+0.05%) ⬆️
parquet_derive/src/ 65.98% <0.00%> (ø)
arrow/src/datatypes/ 64.41% <0.00%> (+0.35%) ⬆️
...row/src/array/builder/ 91.36% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02371d2...32c27fd. Read the comment docs.

@tustvold tustvold merged commit 576069a into apache:master Jul 21, 2022
18 checks passed
Copy link

ursabot commented Jul 21, 2022

Benchmark runs are scheduled for baseline = be0d34d and contender = 576069a. 576069a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
parquet Changes to the parquet crate
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants