-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Decimal128Iter
and Decimal256Iter
and do maximum precision/scale check
#2140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 82.86% 82.82% -0.05%
==========================================
Files 237 237
Lines 61296 61425 +129
==========================================
+ Hits 50792 50874 +82
- Misses 10504 10551 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. |
/// Constructs a new iterator that iterates `Decimal128` values as i128 values. | ||
/// This is kept mostly for back-compatibility purpose. | ||
/// Suggests to use `iter()` that returns `Decimal128Iter`. | ||
#[allow(deprecated)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding the above comment as a deprecation hint?
Benchmark runs are scheduled for baseline = 1621c71 and contender = 73153fe. 73153fe is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Decimal128Iter
and Decimal256Iter
and do maximum precision/scale check
Which issue does this PR close?
Closes #2139.
Closes #2138.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?