Implement peek_next_page and skip_next_page for `InMemoryColumnCh…
#2155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
- Coverage 82.85% 82.77% -0.09%
==========================================
Files 237 237
Lines 61381 61440 +59
==========================================
- Hits 50856 50854 -2
- Misses 10525 10586 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. |
parquet/src/arrow/async_reader.rs
Outdated
| Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792")) | ||
| while self.seen_num_values < self.chunk.num_values { | ||
| return if let Some(buffered_header) = self.next_page_header.as_ref() { | ||
| match buffered_header.type_ { |
There was a problem hiding this comment.
Perhaps we could extract this conversion into a From implementation? This would reduce code duplication in this function and potentially elsewhere
|
Benchmark runs are scheduled for baseline = 37dd037 and contender = aeb2776. aeb2776 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…unkReader`
Which issue does this PR close?
Closes #2129 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?