Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break parquet_derive and arrow_flight tests into their own workflows #2165

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 25, 2022

Which issue does this PR close?

re #2149

Rationale for this change

There is the broader issues described in #2149 of making Arrow CI jobs more efficient by being more fine grained.

In addition, the current test job both takes a long time and takes a lot of disk space -- see #2148 (comment) for example. So reducing the number of checks done in a single job should reduce its chances of running out of disk space

What changes are included in this PR?

Move parquet_derive and arrow_flight jobs into their own workflow

Are there any user-facing changes?

Hopefully less CI failures due to out of disk space

name: "Arrow Flight"

on:
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, I hope to make these triggers more specific (e.g. only run arrow flight tests if arrow or arrow flight are modified, not on parquet only changes) but for now I kept the triggers the same

@alamb alamb marked this pull request as ready for review July 25, 2022 15:57
@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2022

This PR is waiting to run the checks -- once they run I will verify things are ok and then merge it in

@codecov-commenter
Copy link

Codecov Report

Merging #2165 (50d5950) into master (e68852c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2165      +/-   ##
==========================================
- Coverage   82.82%   82.81%   -0.01%     
==========================================
  Files         237      237              
  Lines       61428    61428              
==========================================
- Hits        50875    50873       -2     
- Misses      10553    10555       +2     
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 62.69% <0.00%> (-0.32%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2022

@alamb alamb merged commit ada108b into apache:master Jul 25, 2022
@alamb alamb deleted the alamb/more_workflows branch July 25, 2022 17:48
@ursabot
Copy link

ursabot commented Jul 25, 2022

Benchmark runs are scheduled for baseline = 4a47ab7 and contender = ada108b. ada108b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants