-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break parquet_derive and arrow_flight tests into their own workflows #2165
Conversation
name: "Arrow Flight" | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, I hope to make these triggers more specific (e.g. only run arrow flight tests if arrow or arrow flight are modified, not on parquet only changes) but for now I kept the triggers the same
This PR is waiting to run the checks -- once they run I will verify things are ok and then merge it in |
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
==========================================
- Coverage 82.82% 82.81% -0.01%
==========================================
Files 237 237
Lines 61428 61428
==========================================
- Hits 50875 50873 -2
- Misses 10553 10555 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Benchmark runs are scheduled for baseline = 4a47ab7 and contender = ada108b. ada108b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #2149
Rationale for this change
There is the broader issues described in #2149 of making Arrow CI jobs more efficient by being more fine grained.
In addition, the current
test
job both takes a long time and takes a lot of disk space -- see #2148 (comment) for example. So reducing the number of checks done in a single job should reduce its chances of running out of disk spaceWhat changes are included in this PR?
Move
parquet_derive
andarrow_flight
jobs into their own workflowAre there any user-facing changes?
Hopefully less CI failures due to out of disk space