-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run actions on push to master, pull requests #2166
Conversation
@@ -19,6 +19,9 @@ | |||
name: "Object Store" | |||
|
|||
on: | |||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an oversight -- and it means the object store test does not run against master (until this PR gets merged)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 237 237
Lines 61429 61429
=======================================
Hits 50902 50902
Misses 10527 10527
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Benchmark runs are scheduled for baseline = 13e6f39 and contender = ec3530d. ec3530d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Re #2149
Rationale for this change
While wondering "why did we run out of github actions credits" (when my test jobs are waiting for a runner) I looked at the history of actions https://github.com/apache/arrow-rs/actions and saw several jobs were started twice
I have noticed the same thing on some of my own PRs but I have not found any recent examples.
What changes are included in this PR?
Change jobs to trigger on push to
master
only as well as PRsAre there any user-facing changes?
No