Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove another attempt to cache target directory in action.yaml #2167

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 25, 2022

Which issue does this PR close?

re #2149

Rationale for this change

I removed most of the ineffective "try to cache target" logic in #2150 but I missed one

I noticed this while looking at the failure here: https://github.com/apache/arrow-rs/runs/7500811391?check_suite_focus=true

It basically runs out of disk space when trying to copy all of target into the cache (and it took 3m to do so)

Screen Shot 2022-07-25 at 1 40 32 PM

What changes are included in this PR?

Remove attempt to cache target directory from common setup-builder action

Are there any user-facing changes?

Hopefully less CI failures due to out of disk space

@alamb alamb marked this pull request as ready for review July 25, 2022 17:43
@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2022

Here is another example of burning 2 minutes on what is already the longest job (test workspace): https://github.com/apache/arrow-rs/runs/7498748655?check_suite_focus=true

Screen Shot 2022-07-25 at 1 43 51 PM

@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2022

Ouch here is one job that took 7 minutes to do the post cache: https://github.com/apache/arrow-rs/runs/7501158692?check_suite_focus=true

Screen Shot 2022-07-25 at 1 47 15 PM

@alamb alamb changed the title Remove attempt to cache target directory in action.yaml Remove another attempt to cache target directory in action.yaml Jul 25, 2022
@Dandandan Dandandan merged commit 13e6f39 into apache:master Jul 25, 2022
@ursabot
Copy link

ursabot commented Jul 25, 2022

Benchmark runs are scheduled for baseline = ada108b and contender = 13e6f39. 13e6f39 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/less_cache branch July 25, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants