Break parquet CI into its own workflow, standardize step names #2190
Conversation
| @@ -77,14 +77,23 @@ jobs: | |||
| uses: ./.github/actions/setup-builder | |||
| with: | |||
| rust-version: stable | |||
| - name: Test compilation with different features | |||
| - name: Check compilation | |||
There was a problem hiding this comment.
By breaking each command into its own step it becomes easier to see which check failed on CI. The actual checks run are the same
| run: | | ||
| cargo test -p arrow-flight --all-features | ||
|
|
||
| clippy: |
There was a problem hiding this comment.
I removed the workspace clippy check and instead ran clippy on each individual crate
| # under the License. | ||
|
|
||
| --- | ||
| # tests for parquet crate |
There was a problem hiding this comment.
These tests were extracted from rust.yml
| @@ -94,34 +81,6 @@ jobs: | |||
| export RUSTFLAGS="-C debuginfo=0" | |||
| cargo test | |||
|
|
|||
| clippy: | |||
There was a problem hiding this comment.
Each of the individual crate workflows now run clippy so there is no reason to run it in the workspace as well
| @@ -182,6 +182,10 @@ impl RleEncoder { | |||
| self.bit_writer.bytes_written() | |||
| } | |||
|
|
|||
| pub fn is_empty(&self) -> bool { | |||
There was a problem hiding this comment.
Turns out clippy complains about this in parquet crate, so I fixed it
alamb
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
- Coverage 82.61% 82.60% -0.01%
==========================================
Files 239 239
Lines 62255 62257 +2
==========================================
- Hits 51430 51428 -2
- Misses 10825 10829 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Benchmark runs are scheduled for baseline = 7199b1b and contender = 9d8f700. 9d8f700 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #2149
Rationale for this change
Having the CI checks broken up by crate is a prerequisite for more specific triggering them
What changes are included in this PR?
Are there any user-facing changes?