Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet: export json api with serde_json feature name #2209

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Jul 28, 2022

Rationale for this change

I'm trying to read parquet file without arrow dependency, for the sake of smaller binary size. However, parquet::record::Row#to_json_value is gated with cli feature flag, which introduces other unnecessary crates.

What changes are included in this PR?

Replace feature = cli with feature = serde_json.

Are there any user-facing changes?

No. serde_json is already covered by cli.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 28, 2022
@alamb
Copy link
Contributor

alamb commented Jul 28, 2022

Thanks @flisky

@tustvold
Copy link
Contributor

Thank you for this, would it be possible to instead introduce a top-level "json" feature, as opposed to piggybacking off the optional crates feature. This will be a better UX for users, and future proof it we ever moved to a different JSON implementation

@codecov-commenter
Copy link

Codecov Report

Merging #2209 (aa1fb6d) into master (bc493d9) will decrease coverage by 0.04%.
The diff coverage is 31.11%.

❗ Current head aa1fb6d differs from pull request most recent head f0c0dfe. Consider uploading reports for the commit f0c0dfe to get more accurate results

@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
- Coverage   82.56%   82.52%   -0.05%     
==========================================
  Files         239      239              
  Lines       62269    62304      +35     
==========================================
+ Hits        51415    51417       +2     
- Misses      10854    10887      +33     
Impacted Files Coverage Δ
arrow-flight/examples/flight_sql_server.rs 0.00% <0.00%> (ø)
arrow-flight/src/sql/server.rs 0.00% <0.00%> (ø)
parquet/src/record/api.rs 96.82% <ø> (ø)
.../src/array/builder/primitive_dictionary_builder.rs 80.30% <100.00%> (+1.61%) ⬆️
...rquet/src/arrow/record_reader/definition_levels.rs 87.34% <0.00%> (-1.27%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.62% <0.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tustvold tustvold merged commit 588f408 into apache:master Jul 29, 2022
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 3505afa and contender = 588f408. 588f408 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants