Increase test coverage of ArrowWriter #2220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1764
Rationale for this change
Whilst working on #1764 I realised we didn't have very good test coverage of writing arrow arrays with different encodings to parquet. This is because the arrow_reader fuzz tests write data using the
ColumnWriter
API and not the arrow writer API.In the past these have boiled down to much the same thing, and so this hasn't been an issue. However, as we move to writing directly from arrow arrays, we introduce new codepaths that need testing
What changes are included in this PR?
Ensures good coverage of various encodings, writer versions, etc...
Are there any user-facing changes?
No, this just changes some tests