-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add append_option support to decimal builders #2225
Conversation
There appear to be lint failures |
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
- Coverage 82.52% 82.31% -0.21%
==========================================
Files 240 240
Lines 62267 62445 +178
==========================================
+ Hits 51387 51403 +16
- Misses 10880 11042 +162
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Thanks, should be fixed now @tustvold |
Benchmark runs are scheduled for baseline = 41d96b2 and contender = 561b14c. 561b14c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2224
Rationale for this change
Most of the other builders support append_option which is quite useful for optional fields.
What changes are included in this PR?
Support for append_option in
Decimal128Builder
andDecimal256Builder
.Are there any user-facing changes?
One new public method on
Decimal128Builder
andDecimal256Builder
.