Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Improve Schema metadata mismatch error #2238

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 30, 2022

Which issue does this PR close?

N/A

Rationale for this change

See apache/datafusion#2982

The error just says "schema metadata mismatch" but does not explain what is mismatched.

What changes are included in this PR?

Add details to the error message, and PR just makes the error clearer and explains what is conflicting about the schema

Are there any user-facing changes?

Better error message

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #2238 (5ac3bea) into master (f41fb1c) will increase coverage by 0.00%.
The diff coverage is 70.00%.

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         241      241           
  Lines       62437    62441    +4     
=======================================
+ Hits        51389    51393    +4     
  Misses      11048    11048           
Impacted Files Coverage Δ
arrow/src/datatypes/schema.rs 69.41% <25.00%> (-1.01%) ⬇️
arrow/src/datatypes/mod.rs 99.25% <100.00%> (+<0.01%) ⬆️
...row/src/array/builder/string_dictionary_builder.rs 90.64% <0.00%> (-0.72%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
...rquet/src/arrow/record_reader/definition_levels.rs 89.02% <0.00%> (+1.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@alamb alamb marked this pull request as ready for review August 3, 2022 10:05
@alamb alamb merged commit b826162 into apache:master Aug 3, 2022
@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = 577a93b and contender = b826162. b826162 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants