-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for reading nested decimal arrays from parquet #2254
Conversation
} | ||
|
||
#[test] | ||
#[ignore] // https://github.com/apache/arrow-rs/issues/2253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps unsurprisingly, this is broken. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Testing FTW
Codecov Report
Help us with your feedback. Take ten seconds to tell us how you rate us. |
} | ||
|
||
#[test] | ||
#[ignore] // https://github.com/apache/arrow-rs/issues/2253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Testing FTW
cc @liukun4515 |
Benchmark runs are scheduled for baseline = b879977 and contender = 42b15a8. 42b15a8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Related to #2236.
Rationale for this change
We don't really have very good test coverage of decimal types, and whilst reading #2236 I suspected it might break something. This PR adds tests so that we can have confidence that this feature is not being broken even further.
What changes are included in this PR?
Adds some tests
Are there any user-facing changes?
No