Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for reading nested decimal arrays from parquet #2254

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 1, 2022

Which issue does this PR close?

Related to #2236.

Rationale for this change

We don't really have very good test coverage of decimal types, and whilst reading #2236 I suspected it might break something. This PR adds tests so that we can have confidence that this feature is not being broken even further.

What changes are included in this PR?

Adds some tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 1, 2022
}

#[test]
#[ignore] // https://github.com/apache/arrow-rs/issues/2253
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps unsurprisingly, this is broken. 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Testing FTW

@codecov-commenter
Copy link

Codecov Report

Merging #2254 (16deaac) into master (3032a52) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
+ Coverage   82.29%   82.30%   +0.01%     
==========================================
  Files         243      243              
  Lines       62443    62459      +16     
==========================================
+ Hits        51387    51408      +21     
+ Misses      11056    11051       -5     
Impacted Files Coverage Δ
parquet/src/arrow/arrow_reader.rs 95.12% <100.00%> (+0.12%) ⬆️
...row/src/array/builder/string_dictionary_builder.rs 90.64% <0.00%> (-0.72%) ⬇️
parquet/src/arrow/schema.rs 96.93% <0.00%> (+0.17%) ⬆️
arrow/src/datatypes/datatype.rs 62.61% <0.00%> (+0.31%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.45%) ⬆️
arrow/src/array/array_decimal.rs 90.96% <0.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@alamb alamb changed the title Add tests for nested decimal arrays Add tests for reading nested decimal arrays from parquet Aug 1, 2022
}

#[test]
#[ignore] // https://github.com/apache/arrow-rs/issues/2253
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Testing FTW

@alamb
Copy link
Contributor

alamb commented Aug 1, 2022

cc @liukun4515

@tustvold tustvold merged commit 42b15a8 into apache:master Aug 1, 2022
@ursabot
Copy link

ursabot commented Aug 1, 2022

Benchmark runs are scheduled for baseline = b879977 and contender = 42b15a8. 42b15a8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants