Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated SliceableCursor and InMemoryWriteableCursor #2378

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Remove deprecated SliceableCursor and InMemoryWriteableCursor #2378

merged 1 commit into from
Aug 8, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 8, 2022 •
edited
Loading

These were deprecated in #1775 and #1719 > 2 months ago, I think they can go now

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 8, 2022
tustvold
tustvold commented Aug 8, 2022
View reviewed changes
parquet/src/util/cursor.rs
}

/// Use this type to write Parquet to memory rather than a file.
#[deprecated = "use Vec<u8> instead"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was always an experimental API, and so can also go

@tustvold tustvold changed the title Remove sliceable cursor Remove SliceableCursor and InMemoryWriteableCursor Aug 8, 2022
@tustvold tustvold changed the title Remove SliceableCursor and InMemoryWriteableCursor Remove deprecated SliceableCursor and InMemoryWriteableCursor Aug 8, 2022
@tustvold tustvold merged commit 613b99d into apache:master Aug 8, 2022
@ursabot
Copy link

ursabot commented Aug 8, 2022

Benchmark runs are scheduled for baseline = 3264d7d and contender = 613b99d. 613b99d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added the api-change Changes to the arrow API label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tustvold @ursabot @viirya