Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy by avoiding deprecated functions in chrono #3096

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Fix clippy by avoiding deprecated functions in chrono #3096

merged 3 commits into from
Nov 13, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 12, 2022 •
edited
Loading

Which issue does this PR close?

Closes #3097.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 12, 2022
@viirya viirya mentioned this pull request Nov 12, 2022
Merged
@viirya viirya force-pushed the fix_clippy branch 5 times, most recently from 6cdb556 to 8936cbd Compare November 12, 2022 23:08
@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 12, 2022
@viirya
Copy link
Member Author

viirya commented Nov 13, 2022

cc @tustvold @alamb

@tustvold tustvold merged commit ccc4417 into apache:master Nov 13, 2022
@ursabot
Copy link

ursabot commented Nov 13, 2022

Benchmark runs are scheduled for baseline = 94565bc and contender = ccc4417. ccc4417 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

alamb
alamb reviewed Nov 13, 2022
View reviewed changes
arrow-array/src/delta.rs

assert_eq!(shift_months(base, 0), base);
assert_eq!(shift_months(base, 1), NaiveDate::from_ymd(2021, 1, 31));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 this feels very familiar / similar to the work in https://github.com/apache/arrow-datafusion/pull/4189/files#diff-880863b84a09b210db1fc00012b1f3fbf0ade7f23c4297e15b54474ec65cb814R107

I'll see if I can find a way to remove the copy in DataFusion

@alamb
Copy link
Contributor

alamb commented Nov 13, 2022

Thanks @viirya

@askoa askoa mentioned this pull request Nov 13, 2022
Merged
@alamb alamb mentioned this pull request Nov 25, 2022
Closed
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 26, 2024
@mcheshkov
Allow chrono deprecated functions
8b4a5ca 
Can drop this after rebase on commit ccc4417 "Fix clippy by avoiding deprecated functions in chrono (apache#3096)", first released in 28.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 26, 2024
@mcheshkov
Allow chrono deprecated functions
090ffb0 
Can drop this after rebase on commit ccc4417 "Fix clippy by avoiding deprecated functions in chrono (apache#3096)", first released in 28.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 27, 2024
@mcheshkov
Allow chrono deprecated functions
c329700 
Can drop this after rebase on commit ccc4417 "Fix clippy by avoiding deprecated functions in chrono (apache#3096)", first released in 28.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Sep 5, 2024
@mcheshkov
Allow chrono deprecated functions
7370e8c 
Can drop this after rebase on commit ccc4417 "Fix clippy by avoiding deprecated functions in chrono (apache#3096)", first released in 28.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Sep 5, 2024
@mcheshkov
Allow chrono deprecated functions
03d6fd9 
Can drop this after rebase on commit ccc4417 "Fix clippy by avoiding deprecated functions in chrono (apache#3096)", first released in 28.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb left review comments

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
4 participants
@viirya @ursabot @alamb @tustvold