Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to thrift 0.17 and fix issues #3104

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Upgrade to thrift 0.17 and fix issues #3104

merged 6 commits into from
Nov 14, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Nov 14, 2022 •
edited
Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Nov 14, 2022
jimexist
jimexist commented Nov 14, 2022
View reviewed changes
parquet/Cargo.toml Outdated Show resolved Hide resolved
@jimexist jimexist changed the title (WIP) test with thrift 0.17 and fix issues Upgrade to thrift 0.17 and fix issues Nov 14, 2022
@jimexist
Copy link
Member Author

cargo doc failed, not sure we should just ignore the format file which is autogenerated

@tustvold
Copy link
Contributor

cargo doc failed, not sure we should just ignore the format file which is autogenerated

My vote would be to manually patch up the doc comments it is complaining about. That's what I did before... Might even be scriptable...

@tustvold tustvold added the api-change Changes to the arrow API label Nov 14, 2022
tustvold
tustvold approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added API change as I presume this makes breaking changes to the format module. I think once the docs are fixed this can go in, thank you 👍

@jimexist jimexist merged commit 0900be2 into apache:master Nov 14, 2022
@jimexist jimexist deleted the test-thrift-017 branch November 14, 2022 08:59
@ursabot
Copy link

ursabot commented Nov 14, 2022

Benchmark runs are scheduled for baseline = 430eb84 and contender = 0900be2. 0900be2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to thrift 0.17
3 participants
@jimexist @tustvold @ursabot