Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decimal128, Decimal256, Float16 to DataType::is_numeric #3121

merged 1 commit into from Nov 23, 2022


Copy link

Which issue does this PR close?

Closes #2611

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the api-change Changes to the arrow API label Nov 15, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 15, 2022
@@ -263,30 +263,13 @@ impl fmt::Display for DataType {

impl DataType {
/// Returns true if the type is primitive: (numeric, temporal).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took the opportunity to add #[inline] so that these inline correctly across crate boundaries - which will help with eliding redundant checks

@tustvold tustvold requested a review from viirya November 22, 2022 09:28
@tustvold tustvold merged commit ca92306 into apache:master Nov 23, 2022
21 checks passed
Copy link

ursabot commented Nov 23, 2022

Benchmark runs are scheduled for baseline = 00e5542 and contender = ca92306. ca92306 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api-change Changes to the arrow API arrow Changes to the arrow crate
None yet

Successfully merging this pull request may close these issues.

DataType::is_numeric should match the is_numeric function in Datafusion.
3 participants