Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert Field::metadata to HashMap #3148

Merged
merged 2 commits into from
Nov 21, 2022
Merged

refactor: convert Field::metadata to HashMap #3148

merged 2 commits into from
Nov 21, 2022

Conversation

crepererum
Copy link
Contributor

@crepererum crepererum commented Nov 21, 2022 •
edited by tustvold
Loading

Which issue does this PR close?

Closes #2262.
Closes #3086

Rationale for this change

Consistent metadata types, smaller memory footprint, easier size calculations (see #3147).

What changes are included in this PR?

Field::metadata is now a HashMap instead of a BTreeMap.

Are there any user-facing changes?

⚠️ Breaking Change: Type changed. Iteration order is now undefined.

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Nov 21, 2022
@crepererum crepererum mentioned this pull request Nov 21, 2022
Merged
@tustvold tustvold added the api-change Changes to the arrow API label Nov 21, 2022
tustvold
tustvold reviewed Nov 21, 2022
View reviewed changes
arrow-schema/src/field.rs Outdated
match (self.metadata.get(k), other.metadata.get(k)) {
(None, None) => {}
(Some(_), None) => {
return Ordering::Greater;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct way round?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this doesn't matter since HashMaps aren't ordered by default, so "who goes first" is implementation-defined by arrow, but I'll add a test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tustvold
tustvold reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the Ord implementation is correct, I'm also not sure we actually have any tests of it...

I would feel more comfortable with this, if we had a test that verified this

tustvold
tustvold reviewed Nov 21, 2022
View reviewed changes
arrow-schema/src/field.rs Outdated Show resolved Hide resolved
@crepererum @tustvold
refactor: code formatting
7818f60 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 57f91f2 into apache:master Nov 21, 2022
@ursabot
Copy link

ursabot commented Nov 21, 2022

Benchmark runs are scheduled for baseline = 6f8187f and contender = 57f91f2. 57f91f2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced Nov 25, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Field::metadata to HashMap Encode Field and Schema metadata using the same type
3 participants
@crepererum @ursabot @tustvold