Return slice from GenericByteArray::value_data #3171
Conversation
tustvold
force-pushed
the
byte-array-value-data-slice
branch
from
43b701b
to
345b07e
Compare
tustvold
force-pushed
the
byte-array-value-data-slice
branch
from
345b07e
to
00fd079
Compare
| /// Returns a clone of the value data buffer | ||
| pub fn value_data(&self) -> Buffer { | ||
| self.data.buffers()[1].clone() | ||
| /// Returns the raw value data |
There was a problem hiding this comment.
I also double checked that it is possible to get the buffers (via ArrayData) directly if someone needs access. 👍
impl<T: ByteArrayType> From<GenericByteArray<T>> for ArrayData {
fn from(array: GenericByteArray<T>) -> Self {
array.data
}
}
|
Benchmark runs are scheduled for baseline = 78ab0ef and contender = f749e1d. f749e1d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
This not only avoids unnecessary clones, but is consistent with the general approach of the arrays abstracting away the buffer details.
What changes are included in this PR?
Are there any user-facing changes?