-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctests for BooleanArray. #338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 82.54% 82.56% +0.01%
==========================================
Files 162 162
Lines 44047 44063 +16
==========================================
+ Hits 36359 36379 +20
+ Misses 7688 7684 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @novemberkilo -- I have some comments , but overall this is a great step
Thanks @alamb - I have put up changes to address your comments, squashed and pushed so that I have a single commit here again. |
Looks like the build failure is due to a configuration issue ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @novemberkilo !
I agree -- I will restart the tests |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
the MIRI failure is unrelated to this PR -- it is happening on master too -- see #345. Thanks again @novemberkilo ! |
* Doctests for BooleanArray. * Update arrow/src/array/array_boolean.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Closes #301 .
What changes are included in this PR?
Doctests for
BooleanArray
Are there any user-facing changes?
No.