-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow SliceableCursor
to be constructed from an Arc
directly
#369
Conversation
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes apache#368.
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 162 162
Lines 44175 44175
==========================================
- Hits 36491 36490 -1
- Misses 7684 7685 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368.
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368.
… (#401) This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368. Co-authored-by: Marco Neumann <marco@crepererum.net>
This is backwards-compatible since we change the argument from
Vec<u8>
to
impl Into<Arc<Vec<u8>>>
and the following implementations exists instd:
impl<T, U> Into<U> for T where U: From<T>
(reverse direction)impl<T> From<T> for Arc<T>
(createArc
from any type)Furthermore
Arc<Vec<u8>>
can be passed directly now because the followingimplementations exists:
impl<T> From<T> for T
(identity)Closes #368.