Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raw MapArrayReader #3703

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Add raw MapArrayReader #3703

merged 3 commits into from
Feb 14, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #3610

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

tustvold
tustvold commented Feb 12, 2023
View reviewed changes
arrow-json/src/raw/list_array.rs
@@ -100,7 +93,7 @@ impl<O: OffsetSizeTrait> ArrayDecoder for ListArrayDecoder<O> {
offsets.append(offset)
}

let child_data = self.decoder.decode(tape, &child_pos).unwrap();
let child_data = self.decoder.decode(tape, &child_pos)?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by fix

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 12, 2023
alamb
alamb approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arrow-json/src/raw/mod.rs
assert_eq!(map.value_offsets(), &[0, 1, 3, 5]);

let k: Vec<_> = map_keys.iter().map(|x| x.unwrap()).collect();
assert_eq!(&k, &["a", "a", "b", "c", "a"]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

arrow-json/src/raw/mod.rs Outdated
assert_eq!(&lv, &[Some("foo"), None, None, Some("baz")]);
assert_eq!(map_values.value_offsets(), &[0, 2, 3, 3, 3, 4]);
assert_eq!(map_values.null_count(), 1);
assert!(map_values.is_null(3))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can use our fancy new arrow display writer here to write out the contents of the arrays as well 🤔

@tustvold tustvold merged commit 7083f12 into apache:master Feb 14, 2023
@ursabot
Copy link

ursabot commented Feb 14, 2023

Benchmark runs are scheduled for baseline = ef00365 and contender = 7083f12. 7083f12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tustvold @ursabot @alamb