Remove old JSON Reader and Decoder (#3610) #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
commented
Apr 11, 2023
| use serde_json::Value; | ||
| use arrow_schema::{ArrowError, DataType, Field, Fields, Schema}; | ||
|
|
||
| #[derive(Debug, Clone)] |
There was a problem hiding this comment.
This is just moved from reader.rs
tustvold
force-pushed
the
remove-json-reader
branch
from
e5497e7
to
068c95c
Compare
crepererum
approved these changes
Apr 11, 2023
|
I'm working on porting more of the tests across |
tustvold
commented
Apr 11, 2023
| .collect(); | ||
|
|
||
| let batch = RecordBatch::try_new(self.schema.clone(), columns)?; | ||
| let batch = RecordBatch::from(StructArray::from(decoded)) |
There was a problem hiding this comment.
This is the fix for #4053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3610
Closes #4053
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
This removes a deprecated API