Remove AWS_PROFILE support #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
remove-aws-profile
branch
from
2823654
to
ad8e562
Compare
alamb
approved these changes
May 17, 2023
| @@ -53,11 +53,6 @@ reqwest = { version = "0.11", default-features = false, features = ["rustls-tls" | |||
| ring = { version = "0.16", default-features = false, features = ["std"], optional = true } | |||
| rustls-pemfile = { version = "1.0", default-features = false, optional = true } | |||
|
|
|||
| # AWS Profile support | |||
There was a problem hiding this comment.
I did some archeology and turns out this was added in #2891 -- looks like @timvw @wjones127 and @roeap may be interested so tagging them as well
|
@tustvold the docs are not updated to say that AWS_PROFILE is unsupported. I was confused trying to use AWS_PROFILE today... |
|
I don't see any places within the docs that still refer to AWS_PROFILE, however, documentation improvement PRs are always welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4137
Rationale for this change
The experimental support for
AWS_PROFILEwas always rather tacked on, and didn't really behave correctly. Following #4235 we have a much better story for allowing people to explicitly opt-in to the credentials semantics they want. See https://github.com/apache/arrow-datafusion/pull/6374/files#diff-a5c802a601097328bd118178abf20383d6002d1750733abef0c7d34e1832c340 for an example of what this looks like.What changes are included in this PR?
Are there any user-facing changes?