Derive Eq and PartialEq for SortOptions #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I agree. Could you open an issue for this, so that this ends up in our changelog? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 82.64% 82.65%
=======================================
Files 162 162
Lines 44542 44546 +4
=======================================
+ Hits 36813 36819 +6
+ Misses 7729 7727 -2 ☔ View full report in Codecov by Sentry. |
|
I filed this issue: #426 |
alamb
approved these changes
Jun 8, 2021
jorgecarleitao
approved these changes
Jun 8, 2021
|
🎉 |
alamb
pushed a commit
that referenced
this pull request
Jun 8, 2021
alamb
added a commit
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to compare SortOptions settings is very useful, especially when writing tests
Resolves #426