Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort boolean benchmark #457

Merged
merged 2 commits into from
Jun 19, 2021
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 14, 2021

Which issue does this PR close?

Re #447

Rationale for this change

While reviewing #448 I wanted to measure performance change

What changes are included in this PR?

Benchmark for sorting boolean arrays

@codecov-commenter
Copy link

Codecov Report

Merging #457 (63aa15a) into master (e21f576) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files         164      164           
  Lines       45508    45508           
=======================================
  Hits        37609    37609           
  Misses       7899     7899           
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 90.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21f576...63aa15a. Read the comment docs.

@jimexist
Copy link
Member

was wondering what if you increase it to say 2^16?

@alamb alamb closed this Jun 15, 2021
@alamb alamb deleted the alamb/bool_sort_kernel branch June 15, 2021 11:16
@alamb
Copy link
Contributor Author

alamb commented Jun 19, 2021

Whoops -- not sure why I closed (rather than merging) this branch

@alamb alamb restored the alamb/bool_sort_kernel branch June 19, 2021 11:11
@alamb alamb reopened this Jun 19, 2021
@alamb alamb merged commit 2d8e299 into apache:master Jun 19, 2021
@alamb alamb deleted the alamb/bool_sort_kernel branch June 19, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants