Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new integration scripts (#4963) #4988

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Use new integration scripts (#4963) #4988

merged 1 commit into from
Oct 26, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4963

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 25, 2023
@tustvold tustvold marked this pull request as ready for review October 25, 2023 08:57
pitrou
pitrou reviewed Oct 25, 2023
View reviewed changes
.github/workflows/integration.yml
ARROW_INTEGRATION_CSHARP: ON
ARROW_INTEGRATION_GO: ON
ARROW_INTEGRATION_JAVA: ON
ARROW_INTEGRATION_JS: ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, these are ON by default, so you shouldn't need to set them explicitly (though it doesn't hurt to do so).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to make it obvious how to disable an integration should we wish to

crepererum
crepererum approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@tustvold tustvold merged commit b07dabe into apache:master Oct 26, 2023
31 checks passed
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Nov 8, 2023
@tustvold @alamb
Use new integration scripts (apache#4963) (apache#4988)
5c3dcbb
@alamb alamb mentioned this pull request Nov 8, 2023
Merged
alamb added a commit that referenced this pull request Nov 8, 2023
@alamb @tustvold
Backport CI fixes to 48.0.0_maintenance (#5061)
f91a096 
* Temporarily Disable Java Integration Tests (#4957)

* Add additional integration test dependencies

* Temporarily disable Java

* Remove jpype

* Use new integration scripts (#4963) (#4988)

---------

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@crepererum crepererum crepererum approved these changes

Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable Java Integration Tests
3 participants
@tustvold @crepererum @pitrou