Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Total Ordering for Aggregates and Refactor for Better Auto-Vectorization #5100

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Use Total Ordering for Aggregates and Refactor for Better Auto-Vectorization #5100

merged 7 commits into from
Dec 7, 2023

Commits on Nov 19, 2023

  1. Refactor numeric aggregation kernels to make better use of 

    auto-vectorization.

Remove the explicit simd implementations since the autovectorized
versions are faster on average.

The min/max kernels for floating point numbers now use the total order
relation.
    @jhorstmann
    jhorstmann committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    9ef88c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Comments and cleanup

    @jhorstmann
    jhorstmann committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d04849a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Clippy fixes

    @jhorstmann
    jhorstmann committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9b0b727 View commit details
    Browse the repository at this point in the history

  2. Use largest/smallest bit patterns for float MIN/MAX constants, these … 

    …differ from the canonical NAN bit pattern
    @jhorstmann
    jhorstmann committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    739c52c View commit details
    Browse the repository at this point in the history

  3. Add test coverage for aggregating large non-null and float inputs

    @jhorstmann
    jhorstmann committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    10df385 View commit details
    Browse the repository at this point in the history

  4. Add test with negative NaN

    @jhorstmann
    jhorstmann committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6a6b5f5 View commit details
    Browse the repository at this point in the history

  5. Rename MIN/MAX constants to make it explicit they use the total order… 

    … relation
    @jhorstmann
    jhorstmann committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    175c799 View commit details
    Browse the repository at this point in the history