Pass options to HTTPBuilder in parse_url_opts (#5310) #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
pass-options-http-builder
branch
from
0cf4544
to
704b0ec
Compare
crepererum
approved these changes
Jan 19, 2024
alamb
reviewed
Jan 19, 2024
|
[Also added to the issue] You need to add line 167 back in or this fix doesn't work. |
|
Tests and fix in #5316, thank you for flagging 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5310
Rationale for this change
#4516 added options support to HttpBuilder, but didn't hook it up in parse_url_opts. This fixes that omission.
What changes are included in this PR?
Are there any user-facing changes?