Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Date64 type documentation #5323

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

Jefffrey
Copy link
Contributor

Which issue does this PR close?

Closes #5288

Rationale for this change

What changes are included in this PR?

Update docs of Date64 to hopefully clear up any confusion on its details.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 22, 2024
@Jefffrey
Copy link
Contributor Author

I think doc update is sufficient to close the issue, can add in optional validation later if there is a use case for it

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor copy tweaks

arrow-schema/src/datatype.rs Outdated Show resolved Hide resolved
arrow-schema/src/datatype.rs Outdated Show resolved Hide resolved
arrow-schema/src/datatype.rs Outdated Show resolved Hide resolved
Jefffrey and others added 3 commits January 22, 2024 22:13
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit b594d90 into apache:master Jan 22, 2024
25 checks passed
@Jefffrey Jefffrey deleted the enhance_date64_doc branch January 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion over Date64 array values
2 participants