Add tests for Arrow Flight support for StringViewArray and BinaryViewArray
#5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
|
Thanks @XiangpengHao ! |
alamb
approved these changes
Apr 8, 2024
alamb
changed the title
StringViewArray and BinaryViewArray
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5507.
Rationale for this change
To confirm that
StringViewArrayandBinaryViewArrayworks with Arrow Flight format.What changes are included in this PR?
Just added a few test case to show that they should work, and they indeed work.
Nothing important really, it just works as @alamb said.
Please let me know if I need to make some more complex test cases like ones we added to in the IPC reader test cases.
Are there any user-facing changes?
No